search

popsim-consortium / stdpopsim

A library of standard population genetic models
GNU General Public License v3.0
122 stars 87 forks source link

Vaquita QC #1538

Closed ckyriazis closed 11 months ago

ckyriazis commented 11 months ago

This includes QC for the vaquita species (#1525) and 2 epoch demographic model (#1530). I'm currently failing a strange test related to the parameter table for an AnaPla demographic model so hoping to get some help to figure out why.

Its been a while since I've made any contributions to stdpopsim so apologies if I have messed anything up in the workflow...

petrelharp commented 11 months ago

Oh this is because of #1537. Hm, let's see.

petrelharp commented 11 months ago

@andrewkern do you know how to clear _test_cache/ for CI? Maybe if we just bump the cache number?

petrelharp commented 11 months ago

Ah I think we just needed a rebase

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4766517) 99.86% compared to head (314482f) 99.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1538 +/- ## ======================================= Coverage 99.86% 99.86% ======================================= Files 129 130 +1 Lines 4307 4319 +12 Branches 594 594 ======================================= + Hits 4301 4313 +12 Misses 3 3 Partials 3 3 ``` | [Files](https://app.codecov.io/gh/popsim-consortium/stdpopsim/pull/1538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=popsim-consortium) | Coverage Δ | | |---|---|---| | [stdpopsim/qc/PhoSin.py](https://app.codecov.io/gh/popsim-consortium/stdpopsim/pull/1538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=popsim-consortium#diff-c3RkcG9wc2ltL3FjL1Bob1Npbi5weQ==) | `100.00% <100.00%> (ø)` | | | [stdpopsim/qc/\_\_init\_\_.py](https://app.codecov.io/gh/popsim-consortium/stdpopsim/pull/1538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=popsim-consortium#diff-c3RkcG9wc2ltL3FjL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

petrelharp commented 11 months ago

This looks good to me, shall we merge, @ckyriazis?

ckyriazis commented 11 months ago

yep sounds good!