search

popsim-consortium / stdpopsim

A library of standard population genetic models
GNU General Public License v3.0
126 stars 87 forks source link

various fixes after msprime api updates #1585

Closed silastittes closed 2 months ago

silastittes commented 2 months ago

All the pairs run successfully and generate output now. Might be worth a spot check or two by someone else that a. knows what the previous output looked like b. has a different version of libraries installed (I'm using the analysis2 conda env).

Closes #786

silastittes commented 2 months ago

oh good, I see validation is part of the CI checks. Fixing linting, etc. now.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.81%. Comparing base (ddc70ca) to head (14b6842). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1585 +/- ## ======================================= Coverage 99.81% 99.81% ======================================= Files 130 130 Lines 4354 4354 Branches 597 597 ======================================= Hits 4346 4346 Misses 3 3 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

silastittes commented 2 months ago

Looks like this is failing for the same reasons as main? This should be good now.