search

popsim-consortium / stdpopsim

A library of standard population genetic models
GNU General Public License v3.0
122 stars 86 forks source link

util.is_valid_species_name only supports two words #329

Open jeromekelleher opened 4 years ago

jeromekelleher commented 4 years ago

Need to update the regex to support more than two words, since species can have more than two words in them.

andrewkern commented 4 years ago

you are thinking of being able to include subspecies here? name is meant to capture the binomial nomenclature no?

jeromekelleher commented 4 years ago

you are thinking of being able to include subspecies here? name is meant to capture the binomial nomenclature no?

I dunno, TBH. Is it always strictly two words?

grahamgower commented 4 years ago

Two words for species binomials is correct, but hyphens need to be accepted. Multi-word species epithets exist for historical reasons, and in modern usage it's recommended to hyphenate them.