Analysis-runner pre-commit does no code inspection?

populationgenomics / analysis-runner

MIT License

2 stars 4 forks source link

Analysis-runner pre-commit does no code inspection? #713

Open MattWellie opened 1 week ago

MattWellie commented 1 week ago

Pre-commit in this repo isn't doing any static code inspection? It looks like we can break code and still pass all our CI checks. I can't see anywhere we're explicitly removing these checks...

...Yup. Don't quite understand why the outdated check_allowed_repos call didn't cause a type-checking linter error…

_Originally posted by @jmarshall in https://github.com/populationgenomics/analysis-runner/pull/711#discussion_r1838957763_

MattWellie commented 1 week ago

https://github.com/populationgenomics/analysis-runner/pull/712. so it does break sometimes...