Closed MattWellie closed 1 year ago
Looks good! Manual dispatch for test builds is a good alternative (automated builds on every commit like for cpg_workflows also works good).
There is a lot of documentation and formatting change in this PR besides dockerisation, is this intentional? Would be easier to split documentation and code changes into separate PRs.
There is a lot of documentation and formatting change in this PR besides dockerisation, is this intentional?
Nope, that wasn't intentional! I've changed the base branch now (I'd like the docker changes and corresponding documentation changes to be in main at the same time... but not important)
Fixes
Closes #179
Creates a Dockerfile, a reasonably extensive
.dockerignore
, and a github yaml to run the container building process.Updates bumpversion conf to update the dockerfile contents
AFAIK this repo has secrets enabled ~but no runner to execute, so nothing will be built yet~ the runner(s) are obviously set up for CI, Matt is just an idiot
I'd like to discuss how
cpg_workflows
is built as a comparison - I'm happy either building only from main, or on deliberate invocations of the build action, rather than with every commit.I've added a secondary build file that will build an explicitly
test
version of the image, and will only run when manually invokedChecklist