populationgenomics / automated-interpretation-pipeline

Rare Disease variant prioritisation MVP
MIT License
5 stars 4 forks source link

Containerise (low priority) #180

Closed MattWellie closed 1 year ago

MattWellie commented 1 year ago

Fixes

I'd like to discuss how cpg_workflows is built as a comparison - I'm happy either building only from main, or on deliberate invocations of the build action, rather than with every commit.

I've added a secondary build file that will build an explicitly test version of the image, and will only run when manually invoked

Checklist

vladsavelyev commented 1 year ago

Looks good! Manual dispatch for test builds is a good alternative (automated builds on every commit like for cpg_workflows also works good).

There is a lot of documentation and formatting change in this PR besides dockerisation, is this intentional? Would be easier to split documentation and code changes into separate PRs.

MattWellie commented 1 year ago

There is a lot of documentation and formatting change in this PR besides dockerisation, is this intentional?

Nope, that wasn't intentional! I've changed the base branch now (I'd like the docker changes and corresponding documentation changes to be in main at the same time... but not important)