populationgenomics / automated-interpretation-pipeline

Rare Disease variant prioritisation MVP

MIT License

5 stars 4 forks source link

tag using version, not SHA. Parametrise test tag #189

Closed MattWellie closed 1 year ago

MattWellie commented 1 year ago

Fixes

parametrises the test tag (which should allow the arg to be overwritten)
removed the github SHA from the image name - @illusional mentioned this on a prior PR, but I hadn't realised how massive that name was until the images started being pushed

vladsavelyev commented 1 year ago

removed the github SHA from the image name - @illusional mentioned this on a prior PR, but I hadn't realised how massive that name was until the images started being pushed

Can you give more context on that? What do you mean that the name is massive? Can you give a pointer to Michael's comment?

MattWellie commented 1 year ago

@vladsavelyev The comment I was thinking of is this one. I don't think this would affect the tags being used, as I'm explicitly re-tagging in the workflow, so that change is not consequential.

The main change here is in the docker_test workflow, as the name param wasn't used previously. I'd like to change this up so that I can name the test image after the branch it relates to, for example, so I can have a few different test images in parallel for specific test runs.