search

populationgenomics / hail

Scalable genomic data analysis.
https://hail.is
MIT License
1 stars 1 forks source link

Sept 23 upstream 5 0.2.122 #306

Closed illusional closed 11 months ago

illusional commented 11 months ago

Depends on: https://github.com/populationgenomics/hail/pull/305

Last update to get up to date 😌

jmarshall commented 11 months ago

LGTM up until where you asked me to review it.

I don't understand what that last s/google_storage_bucket/module/g commit is about. Did we change this infra/gcp/main.tf file in our branch somewhere along the line?

illusional commented 11 months ago

@jmarshall, broad don't use this file, just us. So they made changes reflecting what's supposed to happen, but there was a typo. I worked with Daniel to resolve this upstream