populationgenomics / production-pipelines

Genomics workflows for CPG using Hail Batch
MIT License
2 stars 0 forks source link

Read_input requires a String #727

Closed MattWellie closed 2 months ago

MattWellie commented 2 months ago

How did pre-commit not find this? My IDE is now showing this as an error, but the CI which runs MyPy had no issues 🤔

Screenshot 2024-05-06 at 7 42 23 PM
jmarshall commented 2 months ago

Turns out pre-commit did not detect this because it didn't know what get_batch() returns. That can be usefully fixed by #728, but see also populationgenomics/cpg-utils#166's proposal.