search

populationgenomics / production-pipelines

Genomics workflows for CPG using Hail Batch
MIT License
2 stars 0 forks source link

remove "dataset =" from configs #774

Closed MattWellie closed 1 month ago

MattWellie commented 1 month ago

We do a little copy-pasting, and we've been setting dataset and dataset_gcp_project in the default configs.

At best this is harmless, as the default configs are loaded first, then overridden by the analysis-runner defaults, then any manually specified configs.

At worst (if one of these configs is picked manually as a --config CLI arg) the dataset/gcp project will be overridden at runtime, leading to errors (https://batch.hail.populationgenomics.org.au/batches/454726/jobs/1 as an example)