populationgenomics / production-pipelines

Genomics workflows for CPG using Hail Batch
MIT License
6 stars 1 forks source link

Handle deprecated cohorts #922

Open MattWellie opened 2 weeks ago

MattWellie commented 2 weeks ago

Deletion for reference: https://github.com/populationgenomics/seqr-private/issues/215#issuecomment-2261973125

Questions:

  1. Can we do the sample removal without removing the CPG ID from the CustomCohort? I'm not sure if this is valid within the database structure we have

    • when the pipeline pulls each custom cohort, it can check if each of the CPG IDs is still a current/valid sequencing group
  2. If we do need to remove from a CustomCohort, can we mark the whole Cohort as inactive

    • we have an active boolean on a few other entities in the database, but not CCs (AFAIK).
    • If we need to pull samples/CPG IDs out of a Cohort, we should be able to mark the whole cohort as inactive, possibly with a reason to go with it
vivbak commented 3 days ago

Note @dancoates, to be moved to Metamist.