search

populationgenomics / seqr

web-based analysis tool for rare disease genomics
GNU Affero General Public License v3.0
3 stars 1 forks source link

Update deploy actions versions, ignore apply schema cloudrun jobs for… #209

Closed EddieLF closed 3 months ago

EddieLF commented 3 months ago

… feature branches

Updates the deploy actions versions for Gcloud auth with placeholder for GCP federated identity (@illusional can you generate this please). Also updates the setup-node action version.

Also disables the final step (apply schema) for branches that aren't main or staging, since this step fails anyway for branches outside of those two. The commands run by this step are manage.py migrate and manage.py migrate --database=reference_data, and cloudrun jobs to invoke these commands only exist for staging and main.

EddieLF commented 3 months ago

@illusional I've reverted to using the service account json for gcloud auth, my understanding is for setup-gcloud@v2 we need to include a gcloud-auth step, which can use the service account key with the field credentials_json - according to the action docs. Does this seem right?

illusional commented 3 months ago

Maybe just revert that whole block to use the old version of the action, and we'll follow up and do it at that time.