populationgenomics / seqr

web-based analysis tool for rare disease genomics
GNU Affero General Public License v3.0
3 stars 1 forks source link

Add support for ingest of full AIP report and allow saved variant sorting based on AIP tag date. #212

Closed cassimons closed 5 months ago

cassimons commented 6 months ago

Upstream recently added basic support for AIP tags. While useful, CPG requires better granularity of presentation before AIP tags can be usefully released to our collaborator projects.

This PR:

This is functioning on reanalysis dev, you should have access to play. Let me know if you want a report to test upload with.

I have attempted to isolate the changes required for this from the existing code as much as possible to keep upstream merges easy. However, there were a couple of small spots where I needed to update existing logic. If upstream reworks this specific feature we may need to rework this functionality (I am happy to accept this).

We have chosen to align some terminology with existing seqr terminology rather than the current AIP equivalents ("Last Tagged", "restrictive" vs "permissive" etc). I think this is the right call for the context as our aim it to make the results as intuitive as possible for existing seqr users.

Note: this will require a small existing change to the AIP json report. An array of one or more seqr projects must be present in the top-level metadata field of the report.

Out of scope: This will continue to need manual upload of the AIP reports via the UI. We will want to enable syncing via metamist but that will be a separate PR.

React is not my daily driver so very happy for feedback.