populationgenomics / talos

Rare Disease variant reanalysis tool

MIT License

6 stars 4 forks source link

Add httpx redirect #438

Closed MattWellie closed 4 weeks ago

MattWellie commented 4 weeks ago

Fixes

PanelApp API queries are really snippy about whether they should contain trailing slashes. To handle this the httpx get calls need to tolerate the Django redirect
dateutil.relativedelta's interpretation of 'months between two dates' is garbage. It counts the number of calendar months, without considering if those months are multiple years apart. This lead to an erroneous notion of new. see https://github.com/dateutil/dateutil/issues/709

Proposed Changes

allows redirects on httpx calls
manually reimplements the correct time delta

Checklist

[ ] Related Issue created
[ ] Tests covering new change
[x] Linting checks pass

cassimons commented 4 weeks ago

dateutil.relativedelta's interpretation of 'months between two dates' is garbage. It counts the number of calendar months, without considering if those months are multiple years apart. This lead to an erroneous notion of new.

This is amazing!!