search

populationgenomics / variant-curation-portal

Web application for curating loss of function variants
MIT License
1 stars 0 forks source link

Add new annotation fields #35

Closed danielreti closed 1 year ago

danielreti commented 1 year ago

Closes https://github.com/populationgenomics/variant-curation-portal-private/issues/4

daniaki commented 1 year ago

I'll look into updating the github workflow scripts to spin up a postgres db to get the tests working again. Seems relatively straightforward according to this.

danielreti commented 1 year ago

Made the suggested changes - not sure how to write these tests though

daniaki commented 1 year ago

@danielreti Is this still a work in progress or is it ready to be reviewed/merged?

danielreti commented 1 year ago

@daniaki oh it's been ready to be merged, I just don't know how to write the required test

daniaki commented 1 year ago

@danielreti noice, just fixing up the migrations - django doesn't allow two leaf node migrations (i.e this one and the curation comments) but it has a handy facility to merge such migrations into one.