populationgenomics / variant-curation-portal

Web application for curating loss of function variants
MIT License
1 stars 0 forks source link

IGV.js integration into VariantCuration Page #39

Closed danielreti closed 1 year ago

danielreti commented 1 year ago

Closes #33

Front end is working pending decisions for cosmetics like position/size etc. Backend needs to be hooked up @daniaki 🙏

Note I had to fiddle with webpack a bunch to get this working

daniaki commented 1 year ago

@cassimons: relevant file, the rest of the changed files are mostly javascript package updates and file formatting.

Probably not the best implementation, but it's the quickest and easiest. Alternative is to mount the bucket to the app container via GCS Fuse to serve the files using nginx/apache, but this creates other complications like making development and deployment more complex. This solution essentially achieves the same effect by streaming the file directly to the client by getting django to open the file and wrap it in a streaming response. If performance becomes an issue I can look into a better implementation when I have more time to dig into how Cloud Run works.

daniaki commented 1 year ago

This is still missing the logic for storing/retrieving the variant-specific bam paths?

I've added a new reads string array column to the variant table. Once the paths are in the database, and we grant bucket read permission to the service account running the app, it should work.