search

populse / capsul

Collaborative Analysis Platform : Simple, Unifying, Lean
Other
7 stars 14 forks source link

Parsing env variables #248

Closed servoz closed 1 year ago

servoz commented 1 year ago

As discussed in private message, we should put the parse_env_lines() method in soma.utils instead, but in the meantime we can already make the modification in capsul (the method is therefore repeated for each module of capsul.in_context). I don't have freesurfer installed on my computer so I didn't make the modification for the module capsul.in_context.freesurfer, because I can't test the result.

denisri commented 1 year ago

I will merge the PR but here the function is duplicated several times, which will certainly end up with "different" behaviors when we modify/fix one of them. We need to move it in a centralized place soon.

servoz commented 1 year ago

Thanks @denisri ! I can put the function where you want in soma but I do not know where and I do not want to impose a place! Just tell me where you want me to put it.

denisri commented 1 year ago

I've put it in soma.utils.env. I'm moving the calls to it in capsul.

denisri commented 1 year ago

it's moved.

servoz commented 1 year ago

Thanks @denisri !