search

populse / capsul

Collaborative Analysis Platform : Simple, Unifying, Lean
Other
7 stars 14 forks source link

Star-arg unpacking after a keyword argument is strongly discouraged #355

Open DimitriPapadopoulos opened 4 months ago

DimitriPapadopoulos commented 4 months ago

https://github.com/populse/capsul/blob/fbec45b48c464da8001d72478ed449ece7125c42/capsul/process/process.py#L942

https://github.com/populse/capsul/blob/fbec45b48c464da8001d72478ed449ece7125c42/capsul/process/process.py#L1077-L1086

https://github.com/populse/capsul/blob/fbec45b48c464da8001d72478ed449ece7125c42/capsul/process/process.py#L1090-L1096

See flake8-bugbear B026 star-arg-unpacking-after-keyword-arg:

Why is this bad?

In Python, you can use star-argument unpacking to pass a list or tuple of arguments to a function.

Providing a star-argument after a keyword argument can lead to confusing behavior, and is only supported for backwards compatibility.

DimitriPapadopoulos commented 4 months ago

We may remove this exception once we fix these issues: https://github.com/populse/capsul/blob/99c3a47114ad755a1363011a5b2fad29ec335dd3/ruff.toml#L15-L15