populse / mri_conv

3 stars 0 forks source link

Starting point for browsing to the data to be converted in mri_conv #4

Closed servoz closed 5 years ago

servoz commented 5 years ago

Currently the starting point for browsing to the data to be converted is the folder where MRIManager.jar is located. It could be more comfortable to start from the project folder previously defined by the user. So a nice thing should be to pass this path during the call to the mri_conv app.

Current call from mia:

subprocess.call(['java', '-Xmx4096M', '-jar',
                                      config.get_mri_conv_path(),
                                      '[ExportNifti] ' + os.path.join(
                                      self.project.folder, 'data',
                                      'raw_data'),
                                      '[ExportToMIA] PatientName-StudyName-'
                                      'CreationDate-SeqNumber-Protocol-'
                                      'SequenceName-AcquisitionTime',
                                      'CloseAfterExport'])

Expected call from mia, something like:

subprocess.call(['java', '-Xmx4096M', '-jar',
                                      config.get_mri_conv_path(),
                                      projects_directory ,
                                      '[ExportNifti] ' + os.path.join(
                                      self.project.folder, 'data',
                                     'raw_data'),
                                     '[ExportToMIA] PatientName-StudyName-'
                                     'CreationDate-SeqNumber-Protocol-'
                                     'SequenceName-AcquisitionTime',
                                     'CloseAfterExport'])
montigno commented 5 years ago

Ok, I propose to put as an option '[ProjectsDir] '+ projects_directory .

servoz commented 5 years ago

Great !

montigno commented 5 years ago

It's done! (with version 19.3.0a), tell me if it works

servoz commented 5 years ago

Thanks ! We are testing all this and making all the necessary changes on mia's side ASAP

servoz commented 5 years ago

It's seems to work fine ! Thanks