populse / populse_mia

Multiparametric Image Analysis
Other
10 stars 9 forks source link

[Iteration enhancement] exception while updating iterated node name #241

Closed LStruber closed 2 years ago

LStruber commented 2 years ago

An exception is not handled when trying to change iterated node name.

Minimum steps to reproduce:

MIA close itself with an Exeption in the standard output:

Traceback (most recent call last):
  File "/home/lucas/DEV/populse_dev/populse_mia/python/populse_mia/user_interface/pipeline_manager/node_controller.py", line 562, in update_node_name
    old_node = pipeline.nodes[old_node_name]
KeyError: 'iterated_smooth_1'

Two solutions here:

servoz commented 2 years ago

The 2 solutions are OK for me.

So I would tend to think that we should implement what will be the fastest to achieve!

LStruber commented 2 years ago

fix with commit 8c7d0327367d1312e7d6abb8e58d6e3866ee3b05 (solution 2).