search

populse / populse_mia

Multiparametric Image Analysis
Other
10 stars 9 forks source link

[Run step] Run and garbage collect buttons should be disabled when a pipeline is running #259

Closed LStruber closed 2 years ago

LStruber commented 2 years ago

Currently, when a pipeline is running, Run button and Garbage collect button are enabled.

  1. Regarding run button image If I click again on run button, the pipeline is re-run and two concurrent run instances are launched (with two progress bar, see image below). Moreover, at the end of the second run, MIA crashed with exception :

    Traceback (most recent call last):
File "/home/lucas/populse_dev/populse_mia/python/populse_mia/user_interface/pipeline_manager/pipeline_manager_tab.py", line 1180, in finish_execution
status = self.progress.worker.status
AttributeError: 'PipelineManagerTab' object has no attribute 'progress'

    image

  2. Regarding garbage collect button image If it clicked while the pipeline is running, pipeline execution suceed but the file entry is not created in the database (while it is saved on disk !)

As using these buttons during run is not an expected behavior, I think that as suggested in the title, the safe solution is to disable both button while a pipeline is running.

denisri commented 2 years ago

Yes, perfectly true. The run button used to be disabled during run, and I think its disabling has disapeared when the "init" step was merged into the "run" step - f1e29bfd7a233aa9d4756c599e2dbb2b04a03d86 if I'm correct. For the garbage collect, I don't remember but it's possible it has never been disabled. However its disabling should be the same as for the run button. I guess one day we might want to run concurrently several pipelines (with different parameters probably, possibly from different pipeline manager tabs) but this is not taken into account today.