[DataBrowser indexing] When adding a tag to the database, if no default value is set, Mia crashes

[servoz]

When adding a new tag in a project in the DataBrowser,

if we forget to give a default value,

Mia crashes with:

  File "/data/Git_Projects/populse_mia/python/populse_mia/user_interface/pop_ups.py", line 680, in ok_action
    wrong_default_value_type = not check_value_type(default_value,
  File "/data/Git_Projects/populse_mia/python/populse_mia/utils/utils.py", line 113, in check_value_type
    value = ast.literal_eval(value)
  File "/usr/lib64/python3.8/ast.py", line 59, in literal_eval
    node_or_string = parse(node_or_string, mode='eval')
  File "/usr/lib64/python3.8/ast.py", line 47, in parse
    return compile(source, filename, mode, flags,
  File "<unknown>", line 0

    ^
SyntaxError: unexpected EOF while parsing

Only tested with the Integer List Tag type.

• 1 Mia must never crash, we must manage this case. This is not an option.
• 2 What to do?
  • 2-1 A window pop up indicating that a default value is mandatory and we return to the tag setting window until a default value is entered.
  • 2-2 The case is fully handled under the hood by setting a default value if the user does not set it. In the case of a list of integers, for example [0, 0].
  • 2-3 A mixture of 2-1 and 2-2 (my favourite). If no default value is given, a window will open indicating that the value [0, 0] (example taken from 2-2) will be used (OK click) with a possibility to return to the tag setting window to set the default value (Cancel click).
  • 2-4 Like 2-3 but better (no window pop up): When the user defines the type, if there is no defined value for the parameter yet, a default value is automatically set.

[servoz]

I've just pushed a fix into the issue#270_2_3 branch for method 2.3, for now only for strings and lists of strings. From this base, it should be fairly easy to extend to all other types. @YannNdr is currently working on method 2.4, which would be the best to implement (no polluting popup).

[servoz]

After the 9305597 commit the Uts were failing. I just pushed a fix to restart them. So if we want to stick to the 2-3 solution, the issue#270_2_3 branch should do the trick (taking all types into account, for now only strings and lists of strings are handled).

[servoz]

Thanks to @YannNdr's work, we should be able to close this ticket very soon (we are waiting to see the result of the UTs before merging the issue#270_2_4 into master).

However, while testing the new way of adding a tag, I accidentally noticed that there are issues when we want to change the tags value for some types. I will open a new ticket about this because I think it is independent from ticket #270.

[servoz]

The UTs are working correctly, the issue#270_2_4 branch has been merged with master and I have just opened the ticket for the Boolean, Time list and Datetime list types which are currently not well handled (#276). This ticket can now be closed.