porag-m06 / Kanban-Restaurant

This is a JavaScript capstone project: A fancy web application based on 2 external APIs with 3 user interfaces that shows food items and have the option to like, comment and order those items. The project is implemented following GitFlow using HTML, CSS, modular JS. Webpack is used as bundler and Jest for Unit testing.
https://porag-m06.github.io/Kanban-Restaurant/dist/
MIT License
2 stars 1 forks source link

Kanban project issues - Porag, Miki, Maryam #21

Open porag-m06 opened 1 year ago

porag-m06 commented 1 year ago

Hi, please find the Kanban project here: GitHub Project Link. And we have 3 people on our team.

PS: We have yet to add one student as a collaborator to our project. Due to some issue, we could not add him (Student C) yet.

LionRouge1 commented 1 year ago

Hi Team,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

almost

Highlights

Required Changes ♻️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

OyePriscilla commented 1 year ago

Hi @Team,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

so-close-so-close-seth-meyers

Highlights

Assigned individual tasks fairly ✔️ Assigned group task ❎

Required Changes ♻️

Kindly assign the group task fairly to all the members of the group according to the project requirement and previous comment. 👍

Untitled

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

levy002 commented 1 year ago

Hello @Team

Your project is complete! There is nothing else to say other than... Congratulations! 🎉

Status: APPROVED :fire: :fire:

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.