porcino / Av1ador

AV1/VVC/HEVC/VP9/H264 parallel encoder GUI for FFmpeg with preview/comparison
GNU General Public License v3.0
52 stars 2 forks source link

Selected video CRF value not respected after changing video when encoding entire list #19

Closed Anacondo closed 9 months ago

Anacondo commented 9 months ago

I've detected a bug where the application is not respecting the CRF value set in the GUI, and instead chooses a different value (default?), in my case 18. I'm using SVT-AV1 and I noticed a couple times that my encodes were extremely big, especially on noisy sources, so I had to re-run them with a higher CRF value and lost a ton of time because of it. Today, I managed to catch the issue in the middle of an encode: I went to the temp folder and opened one of the ivf.txt files that contain all the parameters:

image

As you can see, the value inside the file is 18, but the specified value in the GUI is 26. I'm not sure why this happens and how to prevent it, but it's quite a time waster and I'm basically forced to run each individual encode manually to make sure the correct CRF value is applied, as this issue only seems to happen to me when I'm encoding a list of files.

Anacondo commented 9 months ago

Just to add, I think I never noticed this before because I usually use CRF18 for all my files, but sometimes on noisy sources I have to increase the value. It seems that it's only when there's a different CRF value specified in the list for one of the files that the issue happens. Hope it helps.

EDIT: Just confirmed the issue by closing the application, removing all the intermediate files except audio and segments, and starting it again. In the GUI the CRF value of 26 is selected, but when I resume the encode the CRF value written to the temp files is 18. I have to clean up, manually increase the value to 25 and then revert back to 26 for the correct value to appear on the temp files.

porcino commented 9 months ago

Looks like it was a bug introduced in this commit dd38d262f7a8a7a68266ccb82a5550b2e01299a7 Good job finding these bugs and reporting back

Anacondo commented 9 months ago

Happy to help! 😄