porcino / Av1ador

AV1/VVC/HEVC/VP9/H264 parallel encoder GUI for FFmpeg with preview/comparison
GNU General Public License v3.0
52 stars 2 forks source link

Feature request: Subtitle burn in #5

Closed jkkma closed 1 year ago

jkkma commented 1 year ago

There are some situations where subtitle burn-in is needed like with .ass subtitles that have special positioning and don't work if you upload them to sites where it isn't supported.

porcino commented 1 year ago

Ok, if you add the filter "subtitles", it's already possible, anyway I just added a menu entry to make it easier to input the path. If you want to override the subtitle style check the documentation here https://ffmpeg.org/ffmpeg-filters.html#subtitles

jkkma commented 1 year ago

im getting this error trying to burn in .ass subs Screenshot 2023-08-05 204439 Is the ffmpeg in av1ador compiled with --enable-libass like it says in the ffmpeg documentation? https://trac.ffmpeg.org/wiki/HowToBurnSubtitlesIntoVideo#subtitlesfilter or is this a different error?

jkkma commented 1 year ago

@porcino I think it was an issue with the file path, some characters not correctly escaped so now i put the video in a simple path and added this custom filter: "subtitles='C\:\\Users\\ayybased\\Videos\\coolvideo.mkv'" and it works. As you can see there was a backslash missing before the : character which was an issue when you use the "Subtitle burn" menu entry helper. Just a suggestion to fix the "Subtitle burn" menu entry you made for last nightly version, which is great btw thanks. Screenshot 2023-08-05 210652

porcino commented 1 year ago

Oh awesome you found the issue, updating it, thanks!