porech / engarde

A go network utility to create a reliable IP tunnel over multiple connections
GNU General Public License v2.0
276 stars 41 forks source link

Excluding/Including not always saving state? #35

Closed Marctraider closed 2 years ago

Marctraider commented 4 years ago

Hi! Just noticed (maybe) a small bug, not exactly sure.

I excluded an interface yesterday and an hour later re-included it.

Now i look today it was included but says xxxxx seconds not received any data (basically 12 ish hours or so), so i excluded and reincluded it just now and it just works fine again instantly.

Maybe there is some small bug that not always properly saves the new state though the API?

ghost commented 4 years ago
Turns out I accidentally set MTU much higher. (1500 instead of 1460 for modem/wisp switch)
Marctraider commented 4 years ago

I dont think i had any messages from the particular interface at all in the logs, just reflecting what I did on the engarde web interface

ghost commented 4 years ago

My bad, I'll open a new issue once it happens again to confirm, maybe it's my aging SBC.

ale-rinaldi commented 4 years ago

Hello @Marctraider , thanks for the issue, it looks quite strange since the inclusion logic is the same for the UI visualization and for the transmission logic, but I will have a look at it. The (slower than I'd want) refactor will totally replace the way it works, by the way: it will be event-based and so it will for sure work in a more reliable way.

Thanks

Marctraider commented 4 years ago

Maybe it was an edge case or maybe it was something on my Debian, but I didn't touch anything OS/network level other than re-exclude/include and it magically started receiving packets again :)

Either way, all works great in general ^^

ghost commented 4 years ago

Maybe it was an edge case or maybe it was something on my Debian, but I didn't touch anything OS/network level other than re-exclude/include and it magically started receiving packets again :)

Either way, all works great in general ^^

Are you using keepalive on the wireguard interface? If so how many seconds?