issue with image_compositor.coffee

porkbuns / shmile

The DIY photobooth, at your service.

75 stars 39 forks source link

issue with image_compositor.coffee #33

Open techyteach-s opened 9 years ago

techyteach-s commented 9 years ago

Hi, I've been getting an error every time I run shmile

For context I am running shmile in raspbian on a Raspberry Pi, in general it is working well, however this is a continuing error.

Once this error has occurred shmile crashes and has to me restarted.

If anyone has any tips, or ideas as to why this error is happening, please let me know, I've tried to figure it out, but unfortunately my skills and understanding a pretty lacking, so I'm struggling!

techyteach-s commented 9 years ago

I may have fixed the error, in line 61 of the code for image_compositor.coffee the argument -size seems to be incorrect and should be -resize. When using -size the user has to determine the the width and height, using -resize the user simply needs a percentage. This seems to be working correctly for me, if anyone else can confirm whether or not I am correct that would be great.

andrewhao commented 9 years ago

@techyteach-s You may be right - the imagemagick version that image_compositor links to is a very specific version that really only worked on my computer. Which version of imagemagick are you using? You can find out by typing convert --version.

techyteach-s commented 9 years ago

@andrewhao I've had a look and I'm using version 6.7.7-10, and I'd say you're probably right, I believe the change is mainly necessary when using it on a Raspberry Pi, as it works fine on OSX.

andrewhao commented 9 years ago

@techyteach-s - you're welcome to fix it - I suggest you look into generalizing a method to pass arguments in a more structured way depending on the version number. Or you could just hack it on your fork :)