search

porsager / busylight

node library for busylight
50 stars 17 forks source link

Fix support for some devices #24

Closed Kasalehlia closed 4 years ago

Kasalehlia commented 4 years ago

Devices with deviceId other than 10171 would get its deviceId overwritten with 10171 and the used protocol would always be the newer, thus breaking support for { "vendorId": 1240, "productId": 63560 }.

porsager commented 4 years ago

Oh my, how did that slip through. Thanks a lot!

lauer commented 2 years ago

But the problem with this fix, seems like it never returns true, and therefore never uses the new protocol, which is needed when the node-hid 2.x is used. (see #28 )