search

porsager / busylight

node library for busylight
50 stars 17 forks source link

Replace CSSParser with PWM Parser #8

Closed mwoodsy closed 7 years ago

mwoodsy commented 7 years ago

Busylight works using PWM values to control the light. PWM values work on a scale of 0-100. Currently the busylight node module sets the busylight value using an RGB which works for colors like red [255, 0, 0] because the light interprets anything over 100 as 100. I noticed an issue when trying to create an orange light. Orange's hex code is #FFA500 which translates to [255, 165, 0] which the busylight interprets as yellow [100,100,0]. If you want to light the busylight as orange using the current set up you would need to pass in #644500 -> [100, 65, 0]

I made a change to use a pwmcolorparser library to handle the conversions so the busylight can correctly display the colors.

porsager commented 7 years ago

Sorry, for the late check up on this, but thanks a lot for the pull request.. I'll just get my hands on a busylight again to test before releasing a new version to npm.

mwoodsy commented 7 years ago

Awesome thanks for accepting the pull request.