Open Kyiro opened 6 months ago
same 👍
It'd honestly be good to get this merged and resolve the error issue at a later date because of those warnings, could we get this PR reviewed?
I'm thinking a hard cut in v4 where we just remove the deno polyfill completely if possible?
As Deno got npm compatibility a while back, I think it might be the right play but this could still get accepted for v3 to avoid headaches
As Deno got npm compatibility a while back, I think it might be the right play but this could still get accepted for v3 to avoid headaches
Yes, the current version on supabase/edge-runtime it's not just a warning, but it triggers an error and become unusable:
runtime has escaped from the event loop unexpectedly: event loop error: TypeError: internals.warnOnDeprecatedApi is not a function
at get rid (ext:deno_io/12_io.js:277:15)
at createWritableStdioStream (https://deno.land/std@0.132.0/node/_process/streams.mjs:29:21)
at https://deno.land/std@0.132.0/node/_process/streams.mjs:68:38
While switching to use this PR the error is gone.
Hello
I've been using postgres.js in a Deno project for a while but I just noticed how outdated the compatibility really is.
Before this gets accepted though, I'd also like to solve these errors when the connection string is invalid/can't connect. I have no idea if these happen on node but I'd assume not.