porsche-design-system / porsche-design-system

Find all the fundamental UXI guidelines and pattern-based web components to build brand driven, consistent and intuitive designs for digital Porsche products.
https://designsystem.porsche.com
Other
458 stars 22 forks source link

[FEATURE] - Make carousel arrows optional #3367

Open arturola opened 1 week ago

arturola commented 1 week ago

Portfolio

No Portfolio

ART and Team

No response

Contact Details

arturojose.latorretirado@nttdata.com

Problem

We have a design requirement in our application where the carousel should not display the navigation arrows.

Solution ideas and examples

Add a boolean property to the carousel component. When this property is set to 'false', the navigation arrows should not be rendered.

Business priority

Medium

Available assisting resources

No response

muellernaumann commented 1 week ago

Hi @arturola! We would currently advise against hiding the prev/next arrows, at least on desktop. There is a variety of literature supporting our assumption that these are a central navigation element for many users. However, we can set up a short sync where you can convince us otherwise.

bvasen commented 1 week ago

Hi @muellernaumann , to be more specific, we are having custom controls for the carousel, displayed in between the carousel slides and not on top of the carousel as the default. As we can control the carousel via the activeSlideIndex from our own controls the only thing missing is to disable the default controls. Currently we are using a workaround to hide the default controls via accessing them in the shadowDom, but we would like to get rid of that workaround.

muellernaumann commented 1 week ago

@bvasen Do you have a visual example of your current implementation? We can also use the appointment next week to discuss the topic afterwards in relation to the horizontal stepper.

bvasen commented 6 days ago

image

marcelbertram commented 2 days ago

@muellernaumann think of a solution where we have a different positioning in the bottom and add arrow key navigation instead to ensure usability / accessibility.

See Apple Slider (https://www.apple.com/de/macbook-pro/): Image