porscheinformatik / clarity-addons

Addons to Clarity Design System
https://porscheinformatik.github.io/clarity-addons
MIT License
81 stars 73 forks source link

Duplicate animated close button for vertical nav burger item #2202

Closed derkoe closed 4 months ago

derkoe commented 5 months ago

Describe the bug

image

https://github.com/porscheinformatik/clarity-addons/assets/123199/0bf16b34-6686-4e6f-9cb6-072eef16decb

To Reproduce

Open the Stackblitz and click on the Hamburger menu: https://stackblitz.com/edit/clarity-dark-theme-clr17-ittm1w?file=package.json

You can see that the "X" icon is shown twice - once it is moved in from the left.

Expected behavior

The "X" close should be shown one.

Versions

App

Additional context

-

derkoe commented 5 months ago

A workaround is to add this to your own styles:

@media screen and (max-width: 992px) and (min-width: 768px) {
  .main-container.open-hamburger-menu .header-hamburger-trigger, .main-container.open-overflow-menu .header-overflow-trigger {
      transform: none;
  }
}
d-m-s commented 5 months ago

thx @derkoe, ad Expected behavior: Checking the docu it seems that the one sliding in from the left is the one to keep, the other one should be removed. So it should be shown once, and there should be no overrides in clarity-addons! The native behavior from clarity should be kept unaltered.

DaSmid commented 4 months ago

Fixed with #2211