porscheinformatik / sonarqube-licensecheck

SonarQube Licensecheck Plugin
Apache License 2.0
156 stars 58 forks source link

Compatibility with Sonar 10 and 9.5+ #375

Closed fvclaus closed 1 year ago

fvclaus commented 1 year ago

Fixes #373

I tested with Sonarqube 10.1, but this should with Sonar 9.5+, because this is the plugin API dependency version that I use. For the 10.x release there haven't been any breaking changes so the plugin API is still using 9.x. 9.5 was the first release were the plugin API was released separately, that's why I choose that version. There is a good chance that this will work with 9.0 - 9.4 as well.

I removed some deprecated classes that did not compile anymore. The frontend wasn't working because of the stricter CSP header that does not allow Vue.js template strings.

fvclaus commented 1 year ago

This is what broke this plugin:

image

https://docs.sonarqube.org/latest/setup-and-upgrade/release-upgrade-notes/

fvclaus commented 1 year ago

@derkoe can you please take a look at this?

derkoe commented 1 year ago

Just tried this with SonarQube 10.1 - still shows a blank screen. Nothing in the console log.

image

fvclaus commented 1 year ago

Just tried this with SonarQube 10.1 - still shows a blank screen. Nothing in the console log.

image

This is what I said in the mail. The administration is still broken, because of the CSP violation. I only touched the dashboard. Up until yesterday, I didn't even know how to get to the administration page, until another user pointed out to me that it is still broken.

fvclaus commented 1 year ago

@derkoe I fixed the administration page:

image

You might need to reload with Ctrl+Shift+R to bypass the cached version of the old frontend.

derkoe commented 1 year ago

Now, we only have to figure out a way to bootstrap the data (mostly SPDX licenses)