search

porscheinformatik / sonarqube-licensecheck

SonarQube Licensecheck Plugin
Apache License 2.0
156 stars 58 forks source link

latest version (6.0.0) doesn't work well with sonar-scanner-cli #409

Closed Isolus closed 7 months ago

Isolus commented 8 months ago

I'm using the sonar-scanner-cli docker image in my CI/CD pipeline to scan and upload all relevant data to SonarQube. Starting with the release of 6.0.0 the license details page is empty.

After some debugging I found out sonar-scanner-cli creates a directory called .scannerwork and sets it as working directory.

I think this change in the latest release causes that the licensecheck looks for the license-details.json relative to the .scannerwork directory and not relative to the project directory anymore:

https://github.com/porscheinformatik/sonarqube-licensecheck/blob/7680c86c8cb09a2044af8b127c914edbf911b0e4/src/main/java/at/porscheinformatik/sonarqube/licensecheck/gradle/GradleDependencyScanner.java#L58

I think .scannerwork will be recreated when starting sonar-scanner-cli so it doesn't make sense to look for license-details.json there. Due to the recreation you can't even copy it there before running the scanner.

I think this change should be reverted or at least be documented.

derkoe commented 7 months ago

@tgwbean can you have a look at that?

tgwbean commented 7 months ago

@derkoe I switched back to using "baseDir" like before. unfortunately I have no experience with the sonar-scanner-cli, so I can only test the scanner running with the gradle build...