port-labs / ocean

🌊 Ocean 🌊 is an innovative solution developed by Port to seamlessly integrate various third-party systems with our developer portal product, empowering engineers to effortlessly prioritize key features and streamline the integration process.
https://ocean.getport.io
Apache License 2.0
104 stars 33 forks source link

Change PagerDuty created_at title to Created At #822

Closed JaanJah closed 2 weeks ago

JaanJah commented 1 month ago

Description

What - Change created_at property title from Create At to Created At in PagerDuty blueprints.json Why - Makes more sense How - Changing the blueprints.json

Fixes https://github.com/port-labs/ocean/issues/821

Type of change

Please leave one option from the following and delete the rest:

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

erikzaadi commented 1 month ago

Heya @JaanJah !

First of all, thanks for your time and contribution, much appreciated!

The way do changelog is towncrier (which you ran), however, we don't commit the changelog file, instead we run towncrier build --yes --version ${NEW_VERSION} which updates the CHANGELOG.md.

In addition, be sure to be up to date with the main branch.

Besides that, the PR looks great!

JaanJah commented 1 month ago

Hi @erikzaadi, thanks for feedback, rebased my branch with upstream, actually having trouble with getting towncrier build command running, it's supposed to be ran in the root directory right or integration directory?

In integration directory I get:

ModuleNotFoundError: No module named 'port_ocean'

and when I do poetry add port_ocean[cli] then I get errors with pyjq dependency:

 _pyjq.c:7693:47: error: no member named 'ob_digit' in 'struct _longobject'
      const digit* digits = ((PyLongObject*)b)->ob_digit;
                            ~~~~~~~~~~~~~~~~~~  ^
  7 warnings and 8 errors generated.
  error: command '/usr/bin/clang' failed with exit code 1

I tried to add the changelog entry manually for now, hopefully you can guide me to make it correct.

Also feedback for the future, the towncrier build command seems to be missing from CONTRIBUTING.md document.

erikzaadi commented 1 month ago

@JaanJah ty for the feedback, duly noted! We'll make sure it's clearer. If you could rebase once more, then I can approve the CI flow to make sure all is ok.

Cheers!

JaanJah commented 1 month ago

@erikzaadi Bumped CHANGELOG version and rebased.

erikzaadi commented 1 month ago

Running CI

erikzaadi commented 1 month ago

@JaanJah one thing that I forgot, do bump the pyproject.toml's version as well

JaanJah commented 1 month ago

@erikzaadi, I updated pyproject.toml now.

erikzaadi commented 2 weeks ago

@JaanJah thank you so much for your contribution! I merged this here to save you the trouble of rebasing again, closing this one.

JaanJah commented 1 week ago

Thanks!