search

port-zero / website

A new website for Port Zero
https://port-zero.com
MIT License
5 stars 2 forks source link

New website #64

Closed ghost closed 5 years ago

ghost commented 5 years ago

Includes the PR #62 and the PR #57. I have fixed broken things. For details see commit messages.

ghost commented 5 years ago

From my side the website from this branch (new-website) is now in a state that can be published to production. Please have a look. If no one finds anything broken and everyone is ok with the state of it @hellerve can merge it.

After the merge the CI should deploy it automatically to https://port-zero.com if it works correctly.

hellerve commented 5 years ago

We also should keep in mind to update staging then!

oskarrough commented 5 years ago

Is it possible to get a fontawesome with just the three icons we're using? To avoid loading the 60kb of unused icons. Not a big deal though.

ghost commented 5 years ago

Is it possible to get a fontawesome with just the three icons we're using? To avoid loading the 60kb of unused icons. Not a big deal though.

I will remove the unused CSS in fontawesome.css but the full "Font Awesome 5 Brands" font is still loaded which is the bigger file. I could look into generating a custom webfont with just the 3 icons that we need right now.

hellerve commented 5 years ago

We should also remove the Twitter icon, since we do not really maintain our Twitter. This makes our icon set shrink to 2, though, at which point it might be interesting to think about whether we should use icons at all.

ghost commented 5 years ago

We should also remove the Twitter icon, since we do not really maintain our Twitter. This makes our icon set shrink to 2, though, at which point it might be interesting to think about whether we should use icons at all.

I have found a good way to generate the icon font with just the icons that we need and I have almost finished the work on it.

ghost commented 5 years ago

@hellerve I have worked on the two remaining remarks that were open and I have resolved them. Let me know if there is something else to do before this PR can be merged.

hellerve commented 5 years ago

This looks good to me now! Could you rebase it so I can merge?

ghost commented 5 years ago

@hellerve I have merged master back into the new-website. So now you can merge it. ;-)

Let's see if the continuous deployment works successfully after the the merge :-)

hellerve commented 5 years ago

It did!!! Yay!