search

port-zero / website

A new website for Port Zero
https://port-zero.com
MIT License
5 stars 2 forks source link

Feature/add jonas aschenbrenner #65

Closed ghost closed 5 years ago

ghost commented 5 years ago

Fixes #59

This needs to be merged after #64

Open question at @hellerve: Regarding the job title am I supposed to replace the "Speciality" in "Speciality Senior Engineers" with something more specific?

hellerve commented 5 years ago

You can leave that part of your title altogether! These differences are purely for internal purposes, and not really relevant for the website. I do appreciate you asking, though.

And in general, we’d usually just take the title as-is, and explain what your specialty is if necessary!

hellerve commented 5 years ago

If you rebase this as well and change your title from “Speciality Senior Engineer” to ”Senior Engineer” we can merge this as well! :+1:

hellerve commented 5 years ago

Do you know why we still see all of the stale commits? Is it possibly because of the rebase?

hellerve commented 5 years ago

Perfect, thank you!

ghost commented 5 years ago

Do you know why we still see all of the stale commits? Is it possibly because of the rebase?

I have now merged master into this PR and I have changed the job title to ”Senior Engineer”. Now the list of changes in this PR is also clean.

Side note: I don't do rebases for pushed branches. I do no-ff merges instead to avoid situations where pulls are broken for other people who had pulled the branch before.

hellerve commented 5 years ago

Perfect!