search

portable-scala / portable-scala-reflect

Platform independent reflection for Scala
BSD 3-Clause "New" or "Revised" License
42 stars 14 forks source link

Update Scala versions #27

Closed sideeffffect closed 3 years ago

sideeffffect commented 3 years ago

Continuation of https://github.com/portable-scala/portable-scala-reflect/pull/24 /cc @LeeTibbert @sjrd

LeeTibbert commented 3 years ago

@sideeffffect Travis is all green. Looked like you have cracked the nut! Thank you.

I will base my sandbox work on this, especially .travis.xml and hope to be ready with the PR adding SN support soon after this is merged.

sjrd commented 3 years ago

OK, let's drop 2.10, but we must do it properly. It should be in its own PR, as it is a feature drop, with two commits:

  1. First commit: Bump the version number at https://github.com/portable-scala/portable-scala-reflect/blob/304fe9ca08e464afb29849ebae54b1392e452ccc/build.sbt#L9 to 1.1.0-SNAPSHOT
  2. Second commit: Drop support for 2.10. This should also remove the TestPlatform.scala in https://github.com/portable-scala/portable-scala-reflect/tree/master/js/src/test/scala/org/portablescala/reflect and https://github.com/portable-scala/portable-scala-reflect/tree/master/jvm/src/test/scala/org/portablescala/reflect
sideeffffect commented 3 years ago

Dropping 2.10 in https://github.com/portable-scala/portable-scala-reflect/pull/29