portablejim / BetterBuildersWands

17 stars 21 forks source link

Wand dupes items instead of using them from inventory #28

Open rikharink opened 7 years ago

rikharink commented 7 years ago

My iron builder wands dupe items instead of using up the item in my inventory. Full client restart doesn't fix the problem, if you need more information please ask. Bug doesn't happen with other player on my server.

Modpack is SF3 3.0.4. Which has better builders wands version 0.10.2 rev 209.

It happened after crafting the wand with the crafting table on a stick from actually additions. Didn't try to reproduce the issue so can't give you nice reproduction steps.

UDPATE: Had my friend craft a wand via the crafting table on a stick and it didn't happen to him.

UPDATE 2: found out it only happens if I have the Rod of the Lands from botania in my inventory and the dupe bug also happens to my friend if he has the Rod of the Lands.

portablejim commented 7 years ago

Can you check having other botania items in your inventory? I changed how the botania integration worked and it seems I broke something. (I'm not that familiar with botania)

Also, It won't get fixed this week.

rikharink commented 7 years ago

I've done some more testing and these are my conclusions:

I can't reproduce the bug in singleplayer it only happens for me in multiplayer. I've tested all the botania rods and found that only the following three rods have the duping bug:

Furthermore the Rod of the Depths makes it so that the builder's wand doesn't work at all.

I suspect that the bug is due to all three rods abillity to create dirt out of mana and the interaction of this mechanic with your mod. I've tested with some other random botania items but none of them seemed to exhibit the duping bug.

hinchy34 commented 7 years ago

I can confirm the bug exists in single player, using the Curse launcher for SF3 v3.0.4 using BBW 0.10.2 rev 209. In Botania, the Rod of the Lands uses the Mana Tablet (portable mana storage) to create dirt.

I too discovered the bug while having the Rod of the Lands in my inventory, the Mana Tablet doesn't cause a dupe issue I found. I thought it was using the stored mana power, but it was not. If you have 3 blocks in your inventory the wand still knows it can only place 3 blocks, but it will not use the blocks if you have the Rod of the Lands on your hotbar or inventory.

I had discovered the bug a few hours earlier with the diamond wand, but it appears the same mechanic runs all types of wands.

portablejim commented 7 years ago

Try 0.11.0. It should not dupe as I disabled the special botania functionality.

RageBoy009 commented 7 years ago

Maybe this helps finding the problem: dupe <----- DUPE POSSIBLE

no dupe<------ DUPE NOT POSSIBLE

hinchy34 commented 7 years ago

@portablejim @RageBoy009 So I just tested it again, the duping only appears to happen when the block you want to duplicate is in-front of the Rod of the Lands anywhere in your inventory. If you put the blocks you want to duplicate after the Rod of the Lands in your inventory space, it will only place the blocks you have, not successfully dupe. Same goes for the hotbar too.

I'm also not familiar enough with mods to test the updated version 0.11.0 by itself without the pack unfortunately.

Kaju-Bubanja commented 6 years ago

Can confirm the bug still exists in version 1.4.4 I am using it with the curse launcher with the curse bundle FTB Presents Direwolf20 1.10. Both if you have the items in the hotbar or in the inventory. Just duplicated some Diamond blocks :) and some Reinforced Obsidian blocks.