search

portablejim / VeinMiner

Minecraft mod to quickly mine veins of ore
GNU Lesser General Public License v3.0
36 stars 31 forks source link

Game Locks Up and Crashes #74

Open Darkosto opened 8 years ago

Darkosto commented 8 years ago

VeinMining with a Tinker's Hammer in an area with a large amount of blocks:

Here's the log while it's locked up: http://pastebin.com/vh66DM1k Here's the crash report: http://pastebin.com/r0t20kjb

This has been a big issue for servers and causes them to completely shut down.

Mod Version: 0.34.1-1.7.10-10r473+4d066f1 MC Version: 1.7.10 Forge Version: 1614

UniZero15 commented 8 years ago

I can confirm that this happens as well. It also happens with the Project Ozone 2 pack.

Funwayguy commented 8 years ago

There needs to be a recursion check before calling this line: https://github.com/portablejim/VeinMiner/blob/1.7/src/main/java/portablejim/veinminer/core/MinerInstance.java#L286

This would prevent VeinMiner re-triggering (and fork bombing Java) from any special tool effects that break more than one block such as hammers.

portablejim commented 7 years ago

Should be fixed. Please test.

portablejim commented 7 years ago

cc #65 .