portagenetwork / roadmap

Developed by the the Alliance in collaboration with University of Alberta, DMP Assistant a data management planning tool, forking the DMP Roadmap codebase
MIT License
6 stars 1 forks source link

Fix Handling of "/contact-us" Within App and Emails #632

Open aaronskiba opened 5 months ago

aaronskiba commented 5 months ago

Related issue:

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

Explanation -Emails to users state please contact us at or visit https://dmp-pgd.ca/contact-us. However, the Contact Us button within the app links to https://portagenetwork.ca/contact-us/ (which re-routes to https://alliancecan.ca/en/services/research-data-management).

Received Email (Testing on UAT) Screenshot from 2024-02-01 11-05-23

dmp-pgd.ca/contact-us Screenshot from 2024-02-01 11-06-53

Contact Us Link Within App Screenshot from 2024-02-01 11-07-51

lagoan commented 5 months ago

@aaronskiba Can you update the email to reflect our application contact us web page?

aaronskiba commented 5 months ago

There is quite a bit of /contact-us handling throughout the app: 1) contact_us_url, contact_us_path, Rails.application.routes.url_helpers.contact_us_url, andRails.application.routes.url_helpers.contact_us_path, and are assigned via the installed contact_us gem 2) contact_us_path is overridden in application_helper.rb via def contact_us_path 3) _dmproadmap.rb has a (commented-out) variable for setting config.x.organisation.contact_us_url 4) branding.yml has a (commented-out) variable for setting Rails.application.config.branding[:organisation][:contact_us_url]

The overriding via 2. does not change Rails.application.routes.url_helpers.contact_us_url or Rails.application.routes.url_helpers.contact_us_url. I'm thinking that the references of Rails.application.routes.url_helpers.contact_us_url should be changed to contact_us_url and the instances of Rails.application.routes.url_helpers.contact_us_path should be changed to contact_us_path.

aaronskiba commented 4 days ago

Here is one other spot where "Contact Us" will have to be updated: /org/admin/:id/admin_edit

Screenshot 2024-07-11 at 11 52 36 AM