Closed aaronskiba closed 3 months ago
We were able to preserve the DMP Assistant branding/styling without having to modify our custom branding/styling. Rather, the issue had to do largely with the v4.1.0 changes in app/assets/stylesheets/application.scss
. ( See commit 9ed065ba1e7cc0f08e0531752bc278af38a586bb )
Please complete the following fields as applicable:
What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
v4.1.0
into4.0.2+portage-4.0.1
According to the v4.1.0 Release Notes:
Pay close attention to your customizations in the
app/views/branded/
directory and any custom JS or CSS you may have for your instance. You may need to make modifications to work with the new JS/CSS Bundling methods. Most notably:application.js
andapplication.css
files have moved. If you were including your custom JS or CSS in this file, make sure that the new versions are importing your files._index.scss
file for your directory. See the one in/app/assets/stylesheets/blocks/
for an example.$color-primary-background
) in your custom SCSS files, you will need to add@use '../variables/colours' as *;
at the top of the file.app/views/branded/layouts/application.html.erb
make sure that you update the javascript and stylesheet link tags in your<head>
section. Seeapp/views/layouts/application.html.erb
.app/javascript/src/utils/tinymce.js
file extension has changed fromjs.erb
tojs
. If you reference this file in your custom JS, you will need to update your import statement.Additional Guidance From DMPRoadmap Regarding Branding/Stylesheets