Developed by the the Alliance in collaboration with University of Alberta, DMP Assistant a data management planning tool, forking the DMP Roadmap codebase
Requests to https://api.ror.org/ are used for fetching organisations that may not already exist within the local db. At this time, DMP Assistant is limiting organisations to only those that exist within the local db. (New organisations are currently only created manually by DMP super admins).
The app is meant to handle the toggling of this config value. Setting Rails.configuration.x.ror.active = false as we did here should limit searching to only the local db (to verify this handling, see app/services/org_selection/search_service.rb).
Override Rails.configuration.x.ror.active to true for duration of ExternalApis::RorService RSpect tests.
Without this change, setting Rails.configuration.x.ror.active = false in config/initializers/external_apis/ror.rb breaks many of the ExternalApis::RorService RSpect tests.
Changes proposed in this PR:
Deactivate External Requests to ROR API
https://api.ror.org/are used for fetching organisations that may not already exist within the local db. At this time, DMP Assistant is limiting organisations to only those that exist within the local db. (New organisations are currently only created manually by DMP super admins).Rails.configuration.x.ror.active = falseas we did here should limit searching to only the local db (to verify this handling, seeapp/services/org_selection/search_service.rb).Override
Rails.configuration.x.ror.activeto true for duration ofExternalApis::RorServiceRSpect tests.Rails.configuration.x.ror.active = falseinconfig/initializers/external_apis/ror.rbbreaks many of theExternalApis::RorServiceRSpect tests.