Developed by the the Alliance in collaboration with University of Alberta, DMP Assistant a data management planning tool, forking the DMP Roadmap codebase
Prior to this commit, if template.visibility == 'organisationally_visible', would always evaluate to false. This is because template.visibility returns an integer value.
app/views/org_admin/templates/_form.html.erb
f.object.visibility == 'organisationally_visible' always evaluates to false. Thus, prior to this commit, the checkbox would always initially render as unchecked.
Also, prior to this commit, the default checked/unchecked values were used (i.e. "1" would be returned when checked, and "0" would be returned when unchecked), and the box is meant to be checked when selecting 'organisationally_visible' ('for internal %{org_name} use only'), which makes the default checked/unchecked values opposite to the mapping of our enums (i.e. {"organisationally_visible"=>0, "publicly_visible"=>1}).
Fixes #754
Changes proposed in this PR:
app/views/org_admin/templates/_show.html.erb
if template.visibility == 'organisationally_visible', would always evaluate to false. This is becausetemplate.visibilityreturns an integer value.app/views/org_admin/templates/_form.html.erb
f.object.visibility == 'organisationally_visible'always evaluates to false. Thus, prior to this commit, the checkbox would always initially render as unchecked.{"organisationally_visible"=>0, "publicly_visible"=>1}).