search

portainer / portainer-compose

Compose setup for Portainer
http://portainer.io
681 stars 303 forks source link

Use Traefik to proxy Edge agent traffic on :8000 to portainer #25

Open robdyke opened 3 years ago

robdyke commented 3 years ago

Fix for #24

robdyke commented 3 years ago

Hi @xe-nvdk This doesn't expose portainer:8000 to the interwebs, it exposes traefik:8000 which routes the TCP to portainer.

(yes, I've had trouble setting up portainer + edge with HTTPS only exposed)

xe-nvdk commented 3 years ago

Hi @xe-nvdk This doesn't expose portainer:8000 to the interwebs, it exposes traefik:8000, which routes the TCP to portainer.

(yes, I've had trouble setting up portainer + edge with HTTPS only exposed)

What problems you had?

Can you make an RP with an alternative name of the file? My idea is have have both options and users pick what fits best for them.

robdyke commented 3 years ago

@xe-nvdk happy with this PR?

xe-nvdk commented 3 years ago

Looks good to me. Because I'm not part of the Portainer team anymore. Let's wait for them to merge this PR.

deviantony commented 3 years ago

Trying to figure out what do we need to make progress on this one, it seems that @baskinsy requested some changes that would need to be added here, would you agree @robdyke ?

Also keen to get your opinion on that one too @xe-nvdk :)

robdyke commented 3 years ago

I'll have another look at this and try to incorporate the suggestion about the host rule

On Tue, 19 Jan 2021, 03:59 Anthony Lapenna, notifications@github.com wrote:

Trying to figure out what do we need to make progress on this one, it seems that @baskinsy https://github.com/baskinsy requested some changes that would need to be added here, would you agree @robdyke https://github.com/robdyke ?

Also keen to get your opinion on that one too @xe-nvdk https://github.com/xe-nvdk :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/portainer/portainer-compose/pull/25#issuecomment-762586944, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHF5AH7LDYI6XI2LXVMKMDS2T7TVANCNFSM4T2U74FQ .