Closed tonivlad closed 1 year ago
Thanks Vlad! 🎉 The tsup
stuff looks good + good catch on the jwt
.
We actually have some coding guidelines that I should have added to the README https://github.com/portalpayments/portalwallet/blob/main/CODING_GUIDELINES.md (sorry I should have done that earlier).
Particularly:
Use null to indicate absense of a value - get rid of all the explicit undefined
s. It's an unrelated change (good PRs focus on single thing), we don't want them, and it'll make the code review much easier.
Functions should do things - dotAnythingWallet()
doesn't for with this. It should dotAnythingToWallet()
like the other functions (the thing it does is convert dot anything to a wallet) , or maybe dotAnythingToWalletAddress()
(the thing it does is convert dot anything to a wallet address - maybe better, as it's more explicit, but we should update the other function names for consistency, and that's better done in a seperate PR).
@mikemaccana
Done & Done
Replaced undefined with null as per the coding guidelines
Renamed the functions:
just saw that someone had the same error that I had soo 😂 this also fixes #2