portalpayments / solana-wallet-names

Resolves wallet names to wallet addresses (and PFPs) across all of Solana. Includes .abc .backpack .bonk .glow .ottr .poor .sol and @ twitter.
https://getportal.app
MIT License
28 stars 8 forks source link

TldParser update to v0.5.2, dotAnything for ANS, build fix #3

Closed tonivlad closed 1 year ago

tonivlad commented 1 year ago

just saw that someone had the same error that I had soo 😂 this also fixes #2

mikemaccana commented 1 year ago

Thanks Vlad! 🎉 The tsup stuff looks good + good catch on the jwt.

We actually have some coding guidelines that I should have added to the README https://github.com/portalpayments/portalwallet/blob/main/CODING_GUIDELINES.md (sorry I should have done that earlier).

Particularly:

  1. Use null to indicate absense of a value - get rid of all the explicit undefineds. It's an unrelated change (good PRs focus on single thing), we don't want them, and it'll make the code review much easier.

  2. Functions should do things - dotAnythingWallet() doesn't for with this. It should dotAnythingToWallet() like the other functions (the thing it does is convert dot anything to a wallet) , or maybe dotAnythingToWalletAddress() (the thing it does is convert dot anything to a wallet address - maybe better, as it's more explicit, but we should update the other function names for consistency, and that's better done in a seperate PR).

tonivlad commented 1 year ago

@mikemaccana

Done & Done

  1. Replaced undefined with null as per the coding guidelines

  2. Renamed the functions:

    • ansMainDomainWallet -> walletToDotAnything
    • dotAnythingWallet -> dotAnythingToWallet