portals-project / portals

Portals is a framework for stateful serverless apps, unifying dataflow streaming with actors
https://www.portals-project.org/
Apache License 2.0
19 stars 2 forks source link

Make SQL engine not print/log by default #225

Closed jspenger closed 1 year ago

jspenger commented 1 year ago

The SQL engine is currently printing lots of text. This should be disabled. When executing the examples, the only thing that should be printed or logged are the explicitly logged results. The current printing is likely some setting which is configurable, it is fine to simply disable it for now, in case we need it for debugging.

See examples:

https://github.com/portals-project/portals/tree/pr216-merge/portals-libraries/src/main/scala/portals/libraries/sql/examples/sqltodataflow

Context:

We are currently working on merging the work on an SQL abstraction https://github.com/portals-project/portals/tree/pr216-merge into a clean state branch https://github.com/portals-project/portals/tree/portals-sql-experiment.

jspenger commented 1 year ago

Fixed in #236