It is not necessary to make the code beautiful. However, at its current state, there are large blocks of uncommented code, and possibly dead / irrellevant code blocks. These should be cleaned up a bit. Perhaps certain things can also be refactored out (similarly how we have refactored out the asker/replier behavior for the DSL currently).
The purpose is to make the code more maintanable, and for making it easier to integrate later into the main branch, possibly with a different SQL parsing backend.
jspenger
commented
1 year ago
The code for the SQL engine is currently messy. We should clean up the code so that it looks a bit more reasonable.
sqllibrary: https://github.com/portals-project/portals/tree/pr216-merge/portals-libraries/src/main/scala/portals/libraries/sql, and its java counterpart: https://github.com/portals-project/portals/tree/pr216-merge/portals-libraries/src/main/java/portals/libraries/sql/internals/calciteNote:
Context:
We are currently working on merging the work on an SQL abstraction https://github.com/portals-project/portals/tree/pr216-merge into a clean state branch https://github.com/portals-project/portals/tree/portals-sql-experiment.