sdcard structure refactor - sdcard part

portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2

GNU General Public License v3.0

3.22k stars 530 forks source link

Closed zxkmm closed 2 months ago

zxkmm commented 5 months ago

for easier review, i separated firmware change part and sdcard change part. This is sdcard change part please don't merge as i need to merge myself. test build(put world map yourself): https://github.com/zxkmm/mayhem-firmware/releases/tag/test_release

zxkmm commented 5 months ago

Sure, but isn’t ensure_dir enough? I can add empty folders and git keep it tho.

zxkmm commented 5 months ago

Please also add an empty USR file with a description stating something like HERE WILL APPEAR YOUR DATA or something equal

Done

gullradriel commented 5 months ago

Once changed with all the suggestions, it will look clear and professional. Let me go and check the other one now ^^

zxkmm commented 5 months ago

all requests fixed

eried commented 2 months ago

I'm closing this PR for now due to a lack of consensus on its benefits. We can revisit and reopen it if compelling reasons for the change come up.