portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2
GNU General Public License v3.0
3.22k stars 530 forks source link

In Audio app, update iq_phase_cal in radio when starting SPEC mode #1972

Closed NotherNgineer closed 5 months ago

NotherNgineer commented 5 months ago

The iq_phase_calibration value from the .ini file was not being programmed into the radio when starting Spec mode in the Audio app, therefore it was only taking effect if the user changed the value while SPEC mode was running.

Fixes this minor issue in PR #1963, per @Brumi-2021

Test version here: https://discord.com/channels/719669764804444213/722101917135798312/1216473993113112636

Brumi-2021 commented 5 months ago

Thanks to both ! @NotherNgineer @gullradriel

I have already validated your test binary , in both r6 (max2837 ) , r9 (max2839) and now it works in both flawlessly . Now , at first booting follows exactly the saved rx_iq_phase_error_cal value in the rx_audio.ini. (tested with uncalibrated / calibrated manual input data) .

Note : as far as I can see , good default data for r6 (max2837 ) is around 13 or 15 /31 , , r9 (max2839) 25 to 31 /63 (so if you can not find a proper set up to calibrate it , you can use a middle value of the range as a good default ).

Thanks

gullradriel commented 5 months ago

How different is a IQ good value tunes signal vs a RxSat good value tuned one ?

gullradriel commented 5 months ago

Ho I see. It's different, it's image rejection. I have to see if it can help the looking glass !

gullradriel commented 5 months ago

Ho my god ! It helps a lot in looking glass, nearly killing the ghost when capturing a keyfob @ 868MHZ !!!!!