search

portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2
GNU General Public License v3.0
3.22k stars 530 forks source link

disable top bar buttons when calibrating touch screen to avoid accidental press #1976

Closed sn0ren closed 4 months ago

sn0ren commented 5 months ago

Describe the bug.

The back button and the other icons in the top bar can be pressed while calibrating the touch screen - which means that if you have a specific offset of the touch screen you will be unable to complete the calibration as you will be hitting the back button when trying to hit the first calibration marker.

The top bar should probably be remove when calibrating, as well as the close button and just have it be one of the physical buttons that exits the calibration procedure.

Also it is unclear from the text, that you have to actually long press/hold down on the markers for a while, before the input is registered. If you just tap them quickly as you would normally with buttons, the input is not registered. Maybe this should more clearly be explained in the text on screen.

Video: https://github.com/portapack-mayhem/mayhem-firmware/assets/5850301/f98cf4d8-bf45-4df7-871e-08bee0a4cb95

Reproduction

Go to calibration procedure and click on screen.

Expected behavior

For the top buttons not to be active when calibrating

Environment/versions

No response

Anything else?

No response

gullradriel commented 5 months ago

I turned it into an enhancement request, I hope you don't mind :-)